Fix color issues for operation output and theme switching#4691
Merged
Conversation
Marc-André Moreau (mamoreau-devolutions)
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to theming and dynamic resource usage for UI elements, with a focus on making colors and styles adapt automatically to the current theme. The changes primarily affect how foreground and background colors are applied to log output, icons, and info bars, increasing consistency and maintainability across light and dark themes.
Theming and dynamic resource improvements:
OperationOutputViewModelnow uses theme-aware brushes for log output lines, looking up resources likeStatusErrorForegroundandLogOutputVerboseForegroundinstead of hardcoded colors. This ensures log output colors adapt to the current theme. (issue [BUG] Avalonia Windows: Update operation popup has poor text contrast #4681)SvgIconcontrol has been updated to automatically select an appropriate foreground color based on the current theme unless explicitly set, and now listens for theme changes to update its appearance dynamically.AppIconForeground) instead of a hardcoded color, improving theme consistency.InfoBar styling simplification:
Code cleanup:
OperationViewModelmenu icon, allowing it to inherit the correct color from the theme.